Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support esm? #300

Open
peterroe opened this issue Jun 6, 2022 · 8 comments
Open

Support esm? #300

peterroe opened this issue Jun 6, 2022 · 8 comments

Comments

@peterroe
Copy link

peterroe commented Jun 6, 2022

No description provided.

@ecrmnn
Copy link
Owner

ecrmnn commented Jun 6, 2022

Sure, I'll be more than happy to review a PR. Please feel free to submit one 😄

@peterroe
Copy link
Author

I'm interested in trying to refactor it, and I'm going to refactor using vite and vitest, can I do this?

@ecrmnn
Copy link
Owner

ecrmnn commented Jun 27, 2022

Why would you need Vite to support ESM? Is there something I’m missing here?

@peterroe
Copy link
Author

No, it's purely due to personal habits, but other than that, vite and vitest are faster and have more features, and make the refactored project more "younger"

@ecrmnn
Copy link
Owner

ecrmnn commented Jun 27, 2022

Would appreciate a PR. Please keep it vanilla without any dependencies 😊

@peterroe
Copy link
Author

OK, I am also think we shouldn't change to much,maybe I should create a new repo like collect-es.js?

@ecrmnn
Copy link
Owner

ecrmnn commented Jun 27, 2022

Simply fork it and make a PR.

If you haven’t created a PR before you might want to check this out https://makeapullrequest.com/

@peterroe
Copy link
Author

I create a new repo to support esm😊 : https://github.com/peterroe/collect-es

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants